Sorry didn't answer, had rough week.
Its just that it is not an HDR to SDR tone mapper and it never will be, the function name is misleading, on top of that hdr makes it so everyone based on his setup/devices could need different adjusting so it need to have some options.
I was just analysing this and comparing with your own (did u change login?) adjusted screenshots from the topic https://hyperion-project.org/t…er-supposedly.631/page-12 and it looks all the same, just look
corrected from the hdr thread ttps://postimg.cc/5jgLNDJz
corrected this thread with 3d lut https://postimg.cc/kVpVwf2Y
As i said its very close, i could even prefer the non 3d lut one, so what is the point of a 3d lut if it look basically the same, a very resource intensive option that even needs to lower the fps to get it to work real-time.
Based on the screenshots i don't think there will be much difference in the led colors, at least not that noticeable if at all.
So it is great to research it more before releasing anything and not call it HDR to SDR tone mapper, refine it more. A more interesting option would be an universal image adjuster that everyone can calibrate for its own purposes and it should be mandatory to have a quick switch option as we can't detect if it was HDR or not so it would need to be switched easily, maybe with presets.
I cant remember now, but do hyperion allows to save v4l2 device setting configuration, like those to fix the image?
/usr/bin/v4l2-ctl --set-ctrl contrast=220
/usr/bin/v4l2-ctl --set-ctrl saturation=255
/usr/bin/v4l2-ctl --set-ctrl brightness=100
/usr/bin/v4l2-ctl --set-ctrl hue=2
So we would have and switchable image adjuster than can do all in one, able to set v4l2 commands and if it is not enough use the 3d lut or other software fixes.
Also regarding the HDR data and 3D LUT, 3d lut is a non linear color mapping, but we dont have the HDR data and it is impossible to know from what rec 2020 colors it was transformed to a rec 709 space, so we can't do the non linear mapping as it is a pure guess, so im just confused how a non linear transformation could help
A helper image
Every data between the big triangle and small triangle is lost without information about what it was, if lets say we had a green like 2020 color between the upper triangles points and we have it transformed in a broken state by a 709 device then it could be any 2020 color between those points, no way to find out what it was.
All im just saying, we can't use a non linear transformation without knowing how it is done. We could do it if we knew how the wrong colors are made, but for now i dont see how this would carry the information we need.
I was thinking about this also, what if every device is wrongly transforming the colors in the same way, if we knew the way, and if it has some data that helps to revert it then we would have something to work on.
If we only knew how the wrong colours are made, i did some tests with ffdshow and madvr tone mappers but couldn't get definitive results.
I see u did also done some research about this here https://github.com/hyperion-project/hyperion.ng/pull/928 didn't have time yet to analyse it, but its very interesting.
And yes i did think the same way, use 3d lut to revert the wrong colors, but there is no data to revert from, this is what i realised and i felt dumb It was never there at least to my current state of knowledge.
On the other hand if we had the HDR raw data it is too complicated to transform it by RPI, its not only the 3d lut, its all the formats data, dolby, hdr10, hdr10+, transform colors smtpe, pq, lightning level, per scene HDR changes, its a lot to do to adjust it, so it is a lot better to have a device to do it for us, i did read some research from the creators of HDFury itself having all the issues i mentioned in my previous post, there is no guarantee that the same HDR data looks the same on different devices, it needs adjusting and they really have a virtual display parameters in grabber to calculate the SDR but it is always an approximation.
This is probably why there only couple and expensive devices working, not even sure they support full specification for dolby vision.
So i think we need to research this better and not rush this, but there is a light in the tunnel for sure.