The json input follows no longer the code pattern of Hyperion. If someone is able to commit a fix regarding this i would appreciate it. Thank you
So the Kodi / XBMC checker json spec is no longer valid for newer Kodi versions? https://github.com/hyperion-project.../libsrc/xbmcvideochecker/XBMCVideoChecker.cpp Is it for all parts or specific ones like request types?
Not sure which version this started, i could confirm it for v15 and v16. If i saw that right, Hyperion expects first a id until it filters for pictures. Which is not given (or no longer) with pictures. A method "picture" was sent after a ("\"method\":\"Player.OnPlay\"") and not after a ID -> else if (reply.contains("\"id\":666")) -> else if (reply.contains("picture"))
So we can skip the id check or does it need that as well? Do you know if there any Kodi wiki docs for its implementation (on their end)?
for picture it looks like we need to skip it. But the json messages are a little bit spammy if you use pictures. Not sure if this leads to unwated switches of Hyperion. We need to try it out . http://kodi.wiki/view/JSON-RPC_API http://kodi.wiki/view/JSON-RPC_API/v6 This may help.
And there is another error that could be fixed Code: Kodi Message: {"error":{"code":-32601,"message":"Method not found."},"id":666,"jsonrpc":"2.0"}
Looks like it's mostly the order of the json string that was off (id before spec) as the commands themselves look valid against V6, not sure if there's a good json reader for QT as right now the code is based on string matches which isn't perfect (really would prefer JSON objects) so we can improve that later but first fix Here's the changed libsrc/xbmcvideochecker/XBMCVideoChecker.cpp for testing , can just copy it in and compile. Haven't got Kodi around right now for testing but can do that later. // Update Added missing brace in one of the commands, they only have examples for V4 but those still look fine the way we use it at least: http://kodi.wiki/view/JSON-RPC_API/Examples Code: {"jsonrpc": "2.0", "method": "Player.GetActivePlayers", "id": 1} which has the id listed last there instead of before jsonrpc
Installed Kodi and testing now, we might lose some backwards compatibility with (very old) Kodi versions but I don't think that can be helped
No problem i think. V15 V16 should be enough. If you want to update Hyperion you may need to update Kodi too
Enabled the Kodi webserver on port 9090 and seeing a successful connection with no errors during playback or pictures however when I display a picture I don't get any lights but not sure how that one is supposed to works as I also have the Hyperion addon installed there. Have it setup like this right now: Code: "xbmcVideoChecker" : { "xbmcAddress" : "10.1.2.54", "xbmcTcpPort" : 9090, "grabVideo" : true, "grabPictures" : true, "grabAudio" : true, "grabMenu" : false, "grabScreensaver" : true, "enable3DDetection" : true },
Ah ok, now I get an error which is a sign that it's least getting a response so will fix the typo and retry Code: KODICHECK INFO: Kodi Message: {"error":{"code":-32700,"message":"Parse error."},"id":n
Much better Code: KODICHECK INFO: Kodi Message: {"id":670,"jsonrpc":"2.0","result":{"version":{"major":1│EFFECTENGINE INFO: Cleaning up Python interpreter 6,"minor":1,"revision":"20160424-c327c53","tag":"stable"}}} KODICHECK INFO: switching to PHOTO mode KODICHECK INFO: switching to VIDEO mode KODICHECK INFO: Kodi Message: {"id":667,"jsonrpc":"2.0","result":{"item":{"file":"smb:│BLACKBORDER INFO: mode:default <ommitted> <ommitted>","id":4287,"label":"<ommitted> e, Rich Eisen","type":"episode"}}} KODICHECK INFO: Kodi Message: {"id":669,"jsonrpc":"2.0","result":{"stereoscopicmode":{ "label":"Disabled","mode":"off"}}} New XBMCvideochecker code is online:
Kodi version looks ok however not that familiar with it though but the tag and version / revision seems valid Code: {"major":1 6,"minor":1,"revision":"20160424-c327c53","tag":"stable"}}} Tmux is messing up my copy / paste again with the multiple screens , will make a PR now so we can test on beta branch.
